Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: deprecate builds with small curl_off_t #9605

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 27, 2022

If curl_off_t turns out to be smaller than 8 bytes, --with-n64-deprecated needs to be used to allow the build to continue. This is to highlight the fact that support for such builds is going away next year.

@bagder bagder added the build label Sep 27, 2022
@bagder
Copy link
Member Author

bagder commented Sep 27, 2022

I tested this by locally bumping the check to check if it is less than 9 bytes instead of 8 - and made sure the command line switch did its job.

bagder added 2 commits Sep 27, 2022
If curl_off_t turns out to be smaller than 8 bytes,
--with-n64-deprecated needs to be used to allow the build to
continue. This is to highlight the fact that support for such builds is
going away next year.

Closes #9605
@bagder bagder force-pushed the bagder/configure-deprecate-small-curl_off_t branch from 8e4f004 to 483b6fd Compare Sep 27, 2022
jay
jay approved these changes Sep 28, 2022
@bagder bagder closed this in 2676683 Sep 28, 2022
@bagder bagder deleted the bagder/configure-deprecate-small-curl_off_t branch Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants