Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: build tests in a separate step from the running of them #9619

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 29, 2022

... to make the output smaller for when you want to look at test failures.

... to make the output smaller for when you want to look at test
failures.
@bagder bagder added the CI Continuous Integration label Sep 29, 2022
@bagder bagder requested review from cmeister2 and mback2k as code owners Sep 29, 2022
@@ -64,10 +64,10 @@ jobs:
- run: make V=1
name: 'make'

- run: make V=1 examples
name: 'make examples'
- run: make V=1 -C tests
Copy link
Member

@mback2k mback2k Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why skip building examples here?

Copy link
Member Author

@bagder bagder Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not intentional to do that change, but then again we could probably just as well skip them in this build as they are built in many others.

Copy link
Member Author

@bagder bagder Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should consider only building the examples in a single specific example job and remove the building of them from all others?

Copy link
Member

@mback2k mback2k Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but we should at least cover all platforms and architectures as we had issues on some in the past with the examples.

@bagder bagder closed this in 0a65228 Sep 29, 2022
@bagder bagder deleted the bagder/gha-build-tests-sep branch Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants