lib: feature deprecation warnings in gcc >= 4.3 #9667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monnerat
force-pushed
the
deprecation
branch
7 times, most recently
from
1513465 to
8c2bfbc
Compare
monnerat
force-pushed
the
deprecation
branch
3 times, most recently
from
d5ed271 to
6b934fb
Compare
monnerat
force-pushed
the
deprecation
branch
2 times, most recently
from
7f5b3c9 to
5e853b5
Compare
bagder
approved these changes
Nov 7, 2022
monnerat
force-pushed
the
deprecation
branch
2 times, most recently
from
b06a4df to
6e780fd
Compare
bagder
reviewed
Nov 14, 2022
docs/libcurl/symbols-in-versions
Outdated
| @@ -886,6 +888,7 @@ CURLOPT_WS_OPTIONS 7.86.0 | |||
| CURLOPT_XFERINFODATA 7.32.0 | |||
| CURLOPT_XFERINFOFUNCTION 7.32.0 | |||
| CURLOPT_XOAUTH2_BEARER 7.33.0 | |||
| CURLOPTDEPRECATED 7.89.0 | |||
There was a problem hiding this comment.
Yes, done and rebased.
Maybe wait for the CI tests to complete before merge?
There was a problem hiding this comment.
CI tests complete now. Failed tests seems not related.
Add a deprecated attribute to functions and enum values that should not be used anymore. This uses a gcc 4.3 dialect, thus is only available for this version of gcc and newer. Note that the _Pragma() keyword is introduced by C99, but is available as part of the gcc dialect even when compiling in C89 mode. It is still possible to disable deprecation at a calling module compile time by defining CURL_DISABLE_DEPRECATION. Gcc type checking macros are made aware of possible deprecations. Some testing support Perl programs are adapted to the extended declaration syntax. Several test and unit test C programs intentionally use deprecated functions/options and are annotated to not generate a warning. New test 1222 checks the deprecation status in doc and header files.
monnerat
force-pushed
the
deprecation
branch
from
6e780fd to
fcded14
Compare
|
Thanks! |
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Dec 5, 2022
Handle the addition of CURL_DEPRECATED() macros. Adding them made some declarations multi-line. Also fix finding some declarations when headers have CRLF EOLs. Ref: curl/curl#9667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a deprecated attribute to functions and enum values that should not be used anymore.
This uses a gcc 4.3 dialect, thus is only available for this version of gcc and newer. Note that the
_Pragma() keyword is introduced by C99, but is available as part of the gcc dialect even when compiling in C89 mode.It is still possible to disable deprecation at a calling module compile time by defining
CURL_DISABLE_DEPRECATION.Gcc type checking macros are made aware of possible deprecations.
Some testing support Perl programs are adapted to the extended declaration syntax.
Several test and unit test C programs intentionally use deprecated functions/options and are annotated to not generate a warning.
New test 1222 checks the deprecation status in doc and header files.