Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.m32: support more options [ci skip] #9680

Closed
wants to merge 23 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Oct 10, 2022

  • Add support for these options:
    -wolfssl, -wolfssh, -mbedtls, -libssh, -psl
    Caveats:
    • -wolfssh requires -wolfssl.
    • -wolfssl cannot be used with OpenSSL backends in parallel.
    • -libssh has build issues with BoringSSL and LibreSSL, and also
      what looks like a world-writable-config vulnerability on Windows.
      Consider it experimental.
    • -psl requires -idn2 and extra libs passed via
      LIBS=-liconv -lunistring.
  • Detect BoringSSL/wolfSSL and set ngtcp2 crypto lib accordingly.
  • Generalize MultiSSL detection.
  • Use else-if syntax. Requires GNU Make 3.81 (2006-04-01).
  • Document more customization options.

This brings over some configuration logic from curl-for-win.

Closes #9680

Cleaner patch w/o whitespace changes: https://github.com/curl/curl/pull/9680/files?w=1

@vszakats vszakats added build Windows Windows-specific labels Oct 10, 2022
@vszakats vszakats closed this in 66e68ca Oct 11, 2022
@vszakats vszakats deleted the m32moredeps branch Oct 11, 2022
obonaventure pushed a commit to mptcp-apps/curl that referenced this pull request Oct 12, 2022
- Add support for these options:
  `-wolfssl`, `-wolfssh`, `-mbedtls`, `-libssh`, `-psl`

  Caveats:
  - `-wolfssh` requires `-wolfssl`.
  - `-wolfssl` cannot be used with OpenSSL backends in parallel.
  - `-libssh` has build issues with BoringSSL and LibreSSL, and also
     what looks like a world-writable-config vulnerability on Windows.
     Consider it experimental.
  - `-psl` requires `-idn2` and extra libs passed via
    `LIBS=-liconv -lunistring`.

- Detect BoringSSL/wolfSSL and set ngtcp2 crypto lib accordingly.
- Generalize MultiSSL detection.
- Use else-if syntax. Requires GNU Make 3.81 (2006-04-01).
- Document more customization options.

This brings over some configuration logic from `curl-for-win`.

Closes curl#9680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Windows Windows-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant