Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: avoid CreateThread if _beginthreadex is available #9705

Closed
wants to merge 1 commit into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented Oct 11, 2022

CreateThread is not threadsafe if mixed with CRT calls.
_beginthreadex on the other hand can be mixed with CRT.

@mback2k mback2k added tests Windows Windows-specific labels Oct 11, 2022
@mback2k mback2k self-assigned this Oct 11, 2022
@mback2k mback2k force-pushed the beginthread branch 3 times, most recently from 126ec46 to 74401ef Compare Oct 15, 2022
CreateThread is not threadsafe if mixed with CRT calls.
_beginthreadex on the other hand can be mixed with CRT.
@mback2k
Copy link
Member Author

mback2k commented Oct 17, 2022

Remaining CI failures are unrelated to this PR. Marking ready for review.

@mback2k mback2k marked this pull request as ready for review Oct 17, 2022
@mback2k mback2k requested review from jay and MarcelRaad Oct 17, 2022
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Might be good if we could define curl_win_thread_handle_t in some common place instead of multiple times separately, but I don't see a common include. Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants