Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy-up: delete HAVE_STRUCT_POLLFD #9707

Closed
wants to merge 1 commit into from
Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Oct 11, 2022

It was only defined in lib/config-win32.h, when building for Vista.

It was only used in select.h, in a condition that also included a check for POLLIN which is a superior choice for this detection and which was already used by cmake and autotools builds.

Delete both instances of this macro.

Closes #xxxx

It was only defined in `lib/config-win32.h`, when building for Vista.

It was only used in `select.h`, in a condition that also included a
check for `POLLIN` which is a superior choice for this detection and
which was already used by cmake and autotools builds.

Delete both instances of this macro.

Closes #xxxx
@vszakats vszakats added build Windows Windows-specific tidy-up labels Oct 11, 2022
@vszakats vszakats changed the title tidy-up: delete unused HAVE_STRUCT_POLLFD tidy-up: delete HAVE_STRUCT_POLLFD Oct 11, 2022
@vszakats vszakats closed this in 0df0aa7 Oct 12, 2022
@vszakats vszakats deleted the winpollfd branch Oct 12, 2022
obonaventure pushed a commit to mptcp-apps/curl that referenced this pull request Oct 12, 2022
It was only defined in `lib/config-win32.h`, when building for Vista.

It was only used in `select.h`, in a condition that also included a
check for `POLLIN` which is a superior choice for this detection and
which was already used by cmake and autotools builds.

Delete both instances of this macro.

Closes curl#9707
obonaventure pushed a commit to mptcp-apps/curl that referenced this pull request Oct 12, 2022
It was only defined in `lib/config-win32.h`, when building for Vista.

It was only used in `select.h`, in a condition that also included a
check for `POLLIN` which is a superior choice for this detection and
which was already used by cmake and autotools builds.

Delete both instances of this macro.

Closes curl#9707
obonaventure pushed a commit to mptcp-apps/curl that referenced this pull request Oct 12, 2022
It was only defined in `lib/config-win32.h`, when building for Vista.

It was only used in `select.h`, in a condition that also included a
check for `POLLIN` which is a superior choice for this detection and
which was already used by cmake and autotools builds.

Delete both instances of this macro.

Closes curl#9707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant