Closed
Conversation
vszakats
added
the
feature-window
jay
approved these changes
Oct 26, 2022
Member
jay
left a comment
jay
left a comment
There was a problem hiding this comment.
The two commits should be combined. The first commit message's first sentence says:
This was necessary to avoid using a header that came via an optional package.
It would be clearer to say
WANT_IDN_PROTOTYPES was necessary to avoid using a header that came via an optional package.
because otherwise it could be read as "This (commit) was necessary to avoid using a header that came via an optional package."
`WANT_IDN_PROTOTYPES` was necessary to avoid using a header that came via an optional package. MS stopped distributing this package some years ago and the winidn definitions are part of standard headers (via `windows.h`) since Vista. Auto-detect Vista inside `lib/idn_win32.c` and enable the manual definitions if building for an older Windows. This allows to delete this manual knob from all build-systems. Also drop the `_SAL_VERSION` sub-case: The definitions are now only enabled with old systems. We assume that code analysis is not run on such systems, allowing us to delete the SAL-friendly flavour of these.
vszakats
force-pushed
the
win-idn-tidy-1
branch
from
bd4b0c5 to
a76e055
Compare
Member
Author
|
Thanks @jay, updated the text, squashed and rebased on master. |
vszakats
removed
the
feature-window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WANT_IDN_PROTOTYPESwas necessary to avoid using a header thatcame via an optional package. MS stopped distributing this package some
years ago and the winidn definitions are part of standard headers (via
windows.h) since Vista.Auto-detect Vista inside
lib/idn_win32.cand enable the manualdefinitions if building for an older Windows.
This allows to delete this manual knob from all build-systems.
Also drop the
_SAL_VERSIONsub-case:The definitions are now only enabled with old systems. We assume that
code analysis is not run on such systems, allowing us to delete the
SAL-friendly flavour of these.