sendf: Remove unnecessary null buffer check#9801
Closed
JDepooter wants to merge 1 commit intocurl:masterfrom
Closed
sendf: Remove unnecessary null buffer check#9801JDepooter wants to merge 1 commit intocurl:masterfrom
JDepooter wants to merge 1 commit intocurl:masterfrom
Conversation
At this point, the psnd->buffer will always exist. We have already allocated a new buffer if one did not previously exist, and returned from the function if the allocation failed.
bagder
approved these changes
Oct 26, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this point, the
psnd->bufferwill always exist. We have already allocated a new buffer if one did not previously exist, and returned from the function if the allocation failed.