Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various typo and grammar fixes in non-code files #9802

Closed
wants to merge 1 commit into from

Conversation

Ayesh
Copy link
Contributor

@Ayesh Ayesh commented Oct 26, 2022

  • Replace Github with GitHub.
  • Replace windows with Windows
  • Replace advice with advise where a verb is used.
  • A few fixes on removing repeated words.
  • Replace a HTTP with an HTTP

@bagder
Copy link
Member

bagder commented Oct 26, 2022

github in lowercase should probably be removed from .github/scripts/spellcheck.words so that the CI jobs better can detect this mistake going forward.

The use of a HTTP... is used in numerous more places if you want to fix it even more. A fair share of them in source comments:

$ git grep -i ' a http' | wc -l
86

@Ayesh
Copy link
Contributor Author

Ayesh commented Oct 26, 2022

Awesome, I will get to it and push to the same PR. Thank you.

@Ayesh Ayesh force-pushed the typoe/1 branch 2 times, most recently from c0b08a0 to 193a840 Compare Oct 26, 2022
@Ayesh
Copy link
Contributor Author

Ayesh commented Oct 26, 2022

I force-pushed (diff)with the rest of the s/a http/an http/ patterns, and manually double checked every chunk. I also capitalized a couple http words in the comments to HTTP where appropriate.

This seems to be all of the typos with it, at least upto cd95ee9.

Apparently the spellchecker picks up on correct GitHub URLs as a typo; not sure what to do.

@bagder
Copy link
Member

bagder commented Oct 26, 2022

But it made two lines too long:

./url.c:1384:81: warning: Longer than 79 columns (LONGLINE)
         /* The requested connection does not use an HTTP proxy or it uses SSL or
./urldata.h:923:81: warning: Longer than 79 columns (LONGLINE)
      struct only because we can do just about any protocol through an HTTP proxy

- Replace `Github` with `GitHub`.
- Replace `windows` with `Windows`
- Replace `advice` with `advise` where a verb is used.
- A few fixes on removing repeated words.
- Replace `a HTTP` with `an HTTP`
bagder
bagder approved these changes Oct 27, 2022
@bagder bagder closed this in 4484270 Oct 27, 2022
@bagder
Copy link
Member

bagder commented Oct 27, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants