Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test telnet server close #9894

Closed
wants to merge 3 commits into from
Closed

Test telnet server close #9894

wants to merge 3 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Nov 11, 2022

Slight change in test telnet server code to have it invoke its close() method.

@bagder bagder added the tests label Nov 11, 2022
@bagder
Copy link
Member

bagder commented Nov 13, 2022

This round at least didn't cause any telnet issues. Should we re-run any particular test a few times to be more sure or do you think this is likely to actually be the proper fix?

@icing
Copy link
Contributor Author

icing commented Nov 14, 2022

In any case, it is a better test code as it calls close() on the server object, as an application is expected to. I could imagine the Python internals to abort sockets not properly closed in deconstruction. But I have not checked.

I have locally not seen the telnet test fails on my mac with this change. I'd say, merge it and we revisit should we see another telnet CONNRESET failure.

@bagder
Copy link
Member

bagder commented Nov 14, 2022

Excellent, thanks!

@bagder bagder closed this in 00ea0aa Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants