Skip to content

Test telnet server close#9894

Closed
icing wants to merge 3 commits intocurl:masterfrom
icing:test-tnserver-impr
Closed

Test telnet server close#9894
icing wants to merge 3 commits intocurl:masterfrom
icing:test-tnserver-impr

Conversation

@icing
Copy link
Contributor

@icing icing commented Nov 11, 2022

Slight change in test telnet server code to have it invoke its close() method.

@bagder bagder added the tests label Nov 11, 2022
@bagder
Copy link
Member

bagder commented Nov 13, 2022

This round at least didn't cause any telnet issues. Should we re-run any particular test a few times to be more sure or do you think this is likely to actually be the proper fix?

@icing
Copy link
Contributor Author

icing commented Nov 14, 2022

In any case, it is a better test code as it calls close() on the server object, as an application is expected to. I could imagine the Python internals to abort sockets not properly closed in deconstruction. But I have not checked.

I have locally not seen the telnet test fails on my mac with this change. I'd say, merge it and we revisit should we see another telnet CONNRESET failure.

@bagder
Copy link
Member

bagder commented Nov 14, 2022

Excellent, thanks!

@bagder bagder closed this in 00ea0aa Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants