Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntlm: fix typo in comment of encrypt_des #9903

wants to merge 1 commit into from


Copy link

@rybak rybak commented Nov 13, 2022

No description provided.

@@ -188,7 +188,7 @@ static void setup_des_key(const unsigned char *key_56,
* Expands a 56 bit key KEY_56 to 64 bit and encrypts 64 bit of data, using
* the expanded key. The caller is responsible for giving 64 bit of valid
* data is IN and (at least) 64 bit large buffer as OUT.
* data as IN and (at least) 64 bit large buffer as OUT.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still reads a little quirky I think. How about rewriting that sentence to:

IN points to 64 bit source data, OUT points to a 64 bit output buffer.

bagder added a commit that referenced this pull request Nov 16, 2022
Reported-by: Andrei Rybak
Fixes #9903
@bagder bagder closed this in df00df1 Nov 16, 2022
@rybak rybak deleted the ntlm-typo branch January 4, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants