ntlm: fix typo in comment of encrypt_des#9903
Closed
rybak wants to merge 1 commit intocurl:masterfrom
Closed
Conversation
bagder
reviewed
Nov 14, 2022
| * Expands a 56 bit key KEY_56 to 64 bit and encrypts 64 bit of data, using | ||
| * the expanded key. The caller is responsible for giving 64 bit of valid | ||
| * data is IN and (at least) 64 bit large buffer as OUT. | ||
| * data as IN and (at least) 64 bit large buffer as OUT. |
Member
There was a problem hiding this comment.
It still reads a little quirky I think. How about rewriting that sentence to:
IN points to 64 bit source data, OUT points to a 64 bit output buffer.
bagder
added a commit
that referenced
this pull request
Nov 16, 2022
Reported-by: Andrei Rybak Fixes #9903
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.