Skip to content

ntlm: fix typo in comment of encrypt_des#9903

Closed
rybak wants to merge 1 commit intocurl:masterfrom
rybak:ntlm-typo
Closed

ntlm: fix typo in comment of encrypt_des#9903
rybak wants to merge 1 commit intocurl:masterfrom
rybak:ntlm-typo

Conversation

@rybak
Copy link
Contributor

@rybak rybak commented Nov 13, 2022

No description provided.

* Expands a 56 bit key KEY_56 to 64 bit and encrypts 64 bit of data, using
* the expanded key. The caller is responsible for giving 64 bit of valid
* data is IN and (at least) 64 bit large buffer as OUT.
* data as IN and (at least) 64 bit large buffer as OUT.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still reads a little quirky I think. How about rewriting that sentence to:

IN points to 64 bit source data, OUT points to a 64 bit output buffer.

bagder added a commit that referenced this pull request Nov 16, 2022
Reported-by: Andrei Rybak
Fixes #9903
@bagder bagder closed this in df00df1 Nov 16, 2022
@rybak rybak deleted the ntlm-typo branch January 4, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants