Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtls internal api update, ssl filter state local #9919

Closed
wants to merge 1 commit into from

Conversation

icing
Copy link
Contributor

@icing icing commented Nov 15, 2022

PR to trigger CI tests

Change of vtls internal API to backends. Localization of state data in filters.

  • almost all backend calls pass the Curl_cfilter intance instead of connectdata+sockindex
  • ssl_connect_data is remove from struct connectdata and made internal to vtls
  • ssl_connect_data is allocated in the added filter, kept at cf->ctx
  • added function to let a ssl filter access its ssl_primary_config and ssl_config_data this selects the propert subfields in conn and data, for filters added as plain or proxy
  • adjusted all backends to use the changed api
  • adjusted all backends to access config data via the exposed functions, no longer using conn or data directly

lib/vtls/gskit.c Show resolved Hide resolved
@bagder

This comment was marked as off-topic.

@jay

This comment was marked as off-topic.

@icing icing force-pushed the cf-vtls branch 5 times, most recently from fd69cff to 62534b7 Compare November 19, 2022 13:39
lib/cfilters.c Outdated Show resolved Hide resolved
lib/cfilters.h Outdated Show resolved Hide resolved
…in filters.

                        - almost all backend calls pass the Curl_cfilter intance instead of connectdata+sockindex
                        - ssl_connect_data is remove from struct connectdata and made internal to vtls
                        - ssl_connect_data is allocated in the added filter, kept at cf->ctx
                        - added function to let a ssl filter access its ssl_primary_config and ssl_config_data
                          this selects the propert subfields in conn and data, for filters added as plain or proxy
                        - adjusted all backends to use the changed api
                        - adjusted all backends to access config data via the exposed functions, no longer using conn or data directly

                        cfilter renames for clear purpose:

                        - methods `Curl_conn_*(data, conn, sockindex)` work on the complete filter chain at `sockindex` and connection `conn`.
                        - methods `Curl_cf_*(cf, ...)` work on a specific Curl_cfilter instance.
                        - methods `Curl_conn_cf()` work on/with filter instances at a connection.

                        - rebased and resolved some naming conflicts
                        - hostname validation (und session lookup) on SECONDARY use the same name as on FIRST (again).

                    new debug macros and removing connectdata from function signatures where not needed.
                    adapting schannel for new Curl_read_plain paramter.
bagder
bagder approved these changes Nov 22, 2022
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this!

@bagder bagder closed this in af22c2a Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants