Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mime: relax easy/mime structures binding #9927

Closed
wants to merge 1 commit into from

Conversation

monnerat
Copy link
Contributor

Recent changes to the library have released the strict need for an early binding of mime structures to an easy handle.

This constraint currently forces to create the handle before the mime structure and the latter cannot be attached to another handle once created (see https://curl.se/mail/lib-2022-08/0027.html).

This commit removes the handle pointers from the mime structures allowing more flexibility on their use.

When an easy handle is duplicated, bound mime structures must however still be duplicated too as their components hold send-time dynamic information.

bagder
bagder approved these changes Nov 16, 2022
@jay
Copy link
Member

jay commented Nov 17, 2022

"Recent changes to the library have released the strict need for an early binding of mime structures to an easy handle."

Can you please cite those changes as references in the commit, or just briefly explain what they are?

@monnerat
Copy link
Contributor Author

Can you please cite those changes as references in the commit

Done.

Deprecation and removal of codeset conversion support from the library
have released the strict need for an early binding of mime structures to
an easy handle (curl@2610142).

This constraint currently forces to create the handle before the mime
structure and the latter cannot be attached to another handle once
created (see https://curl.se/mail/lib-2022-08/0027.html).

This commit removes the handle pointers from the mime structures allowing
more flexibility on their use.

When an easy handle is duplicated, bound mime structures must however
still be duplicated too as their components hold send-time dynamic
information.
@bagder
Copy link
Member

bagder commented Nov 28, 2022

Thanks!

@monnerat monnerat deleted the mime-no-data branch November 28, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants