Darwinssl: Test for errSecSuccess in PKCS12 import rather than noErr #993

Merged
merged 1 commit into from Sep 6, 2016

Projects

None yet

2 participants

@danielgustafsson
Contributor

Small nitpick: while noErr and errSecSuccess are defined as the same value, the API documentation states that SecPKCS12Import() returns errSecSuccess if there were no errors in importing. Ensure that a future change of the defined value doesn't break (however unlikely) and be consistent with the API docs.

https://developer.apple.com/reference/security/1396915-secpkcs12import

@danielgustafsson danielgustafsson Test for errSecSuccess in PKCS12 import rather than noErr
While noErr and errSecSuccess are defined as the same value, the API
documentation states that SecPKCS12Import() returns errSecSuccess if
there were no errors in importing. Ensure that a future change of the
defined value doesn't break (however unlikely) and be consistent with
the API docs.
0cd9679
@bagder bagder merged commit 022dbdb into curl:master Sep 6, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bagder
Member
bagder commented Sep 6, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment