New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darwinssl: Test for errSecSuccess in PKCS12 import rather than noErr #993

Merged
merged 1 commit into from Sep 6, 2016

Conversation

Projects
None yet
2 participants
@danielgustafsson
Copy link
Member

danielgustafsson commented Sep 6, 2016

Small nitpick: while noErr and errSecSuccess are defined as the same value, the API documentation states that SecPKCS12Import() returns errSecSuccess if there were no errors in importing. Ensure that a future change of the defined value doesn't break (however unlikely) and be consistent with the API docs.

https://developer.apple.com/reference/security/1396915-secpkcs12import

Test for errSecSuccess in PKCS12 import rather than noErr
While noErr and errSecSuccess are defined as the same value, the API
documentation states that SecPKCS12Import() returns errSecSuccess if
there were no errors in importing. Ensure that a future change of the
defined value doesn't break (however unlikely) and be consistent with
the API docs.

@bagder bagder merged commit 022dbdb into curl:master Sep 6, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bagder

This comment has been minimized.

Copy link
Member

bagder commented Sep 6, 2016

thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.