Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyper: classify headers as CONNECT and 1XX #9947

Conversation

seanmonstar
Copy link
Contributor

@seanmonstar seanmonstar commented Nov 18, 2022

I was debugging tests 1941 and 1942, and eventually noticed that curl_easy_header was fetching headers from CONNECT and 1XX responses as CURLH_HEADER, which was incorrect. I found that the issue was that the writetype was not being set, as it is in http.c.

I don't know if there's a better or more idiomatic way you prefer this written.

@bagder bagder added the Hyper label Nov 19, 2022
bagder
bagder approved these changes Nov 19, 2022
Copy link
Member

@bagder bagder left a comment

nice!

@bagder bagder closed this in 8c859cd Nov 19, 2022
@bagder
Copy link
Member

bagder commented Nov 19, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants