Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netware: remove leftover traces #9966

Closed

Conversation

danielgustafsson
Copy link
Member

Commit 3b16575 removed support for building on Novell Netware, but a few leftover traces remained. This removes the last bits.

Commit 3b16575 removed support for
building on Novell Netware, but a few leftover traces remained. This
removes the last bits.
@@ -31,9 +31,6 @@
#include <fcntl.h>
#endif

#if (defined(HAVE_IOCTL_FIONBIO) && defined(NETWARE))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep this #include <sys/filio.h> but change the condition to #ifdef HAVE_SYS_FILIO_H? I'm trying to revive support for classic Mac OS and it needs this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't your patch just as well include it if it needs it? I understand that it'll be a merge conflict once this goes in (if it does) but it should be trivially fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

bagder
bagder approved these changes Nov 22, 2022
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danielgustafsson
Copy link
Member Author

danielgustafsson commented Nov 23, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants