This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Add getting file size and number of collection files in main panel an… #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d side panel Feature #14349 Arvados-DCO-1.1-Signed-off-by: Daniel Kos <daniel.kos@contractors.roche.com>
burzomir
reviewed
Oct 16, 2018
| @@ -207,11 +207,12 @@ const toggleParentNodeSelection = (id: string) => <T>(tree: Tree<T>) => { | |||
| const mapNodeValue = <T, R>(mapFn: (value: T) => R) => (node: TreeNode<T>): TreeNode<R> => | |||
| ({ ...node, value: mapFn(node.value) }); | |||
|
|
|||
| const getRootNodeChildren = <T>(tree: Tree<T>) => | |||
| const getRootNodeChildrenIds = <T>(tree: Tree<T>) => | |||
There was a problem hiding this comment.
getRootNodeChildrenIds = getNodeDescendantsIds(TREE_ROOT_ID)
| fileSize = flattenFiles.reduce((acc, f) => { | ||
| return acc + (f && f.value.type === CollectionFileType.FILE ? f.value.size : 0); | ||
| }, 0); | ||
| } |
There was a problem hiding this comment.
To make the most of reduce capabilities it could also be written as:
const [fileCount, fileSize] = flattenFiles.reduce(
([fileCount, fileSize], f) =>
f.value.type === CollectionFileType.FILE
? [fileCount +1, fileSize + 1]
: [fileCount, fileSize], [0, 0])
src/models/collection.ts
Outdated
| @@ -14,6 +14,8 @@ export interface CollectionResource extends TrashableResource { | |||
| replicationDesired: number; | |||
| replicationConfirmed: number; | |||
| replicationConfirmedAt: string; | |||
| fileSize: number; | |||
There was a problem hiding this comment.
IMO it's not the best idea to extend CollectionResource since it's purpose was to represent API collection structure 1:1.
There was a problem hiding this comment.
So what's your proposal?
Feature #14349 Arvados-DCO-1.1-Signed-off-by: Daniel Kos <daniel.kos@contractors.roche.com>
burzomir
approved these changes
Oct 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d side panel
Feature #14349
Arvados-DCO-1.1-Signed-off-by: Daniel Kos daniel.kos@contractors.roche.com