Keep track of which apps requested which scopes for users #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us in the future to create the concept of a third-party apps. These apps will explictly have to request the user if they are willing to give permission to certain scopes. Right now all scopes are auto-granted, because all apps are considered 'first party' and trusted.
pschwyter
approved these changes
Oct 4, 2022
Co-authored-by: Philippe Schwyter <phil@badgateway.net>
Yeah this is correct. We currently only have 'privileged' applications. Auto-granting these scopes makes sense for first party-applications. But for third-party applications users would have to explicitly consent to these scopes. This entire PR is really to set up the plumbing to make that possible in the future. Tracking scopes for privileged applications is not super useful by itself. |
Co-authored-by: Philippe Schwyter <phil@badgateway.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us in the future to create the concept of a third-party apps. These apps will explicitly have to request the user if they are willing to give permission to certain scopes.
Right now all scopes are auto-granted, because all apps are considered 'first party' and trusted.
This is also a step towards OpenID Connect support.
Fixes #435