Skip to content

feat: add warning phishing banner #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
0xPearce wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat: add warning phishing banner #1699

0xPearce wants to merge 11 commits into from

Conversation

@0xPearce
Copy link
Collaborator

@0xPearce 0xPearce commented Nov 25, 2025 •
edited
Loading

  • Added subtitle to the banner component
  • Implemented the warning phishing banner
  • added e2e tests

@vercel
Copy link

vercel bot commented Nov 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
curve-dapp Ready Ready Preview Comment Dec 5, 2025 9:53am
curve-dapp-storybook Ready Ready Preview Comment Dec 5, 2025 9:53am

@0xPearce 0xPearce marked this pull request as draft November 25, 2025 12:34
@0xPearce 0xPearce marked this pull request as ready for review November 25, 2025 14:49
DanielSchiavini
DanielSchiavini previously approved these changes Nov 25, 2025
View reviewed changes
@0xAlunara
Copy link
Collaborator

0xAlunara commented Nov 25, 2025 •
edited
Loading

Alignment doesn't seem to work correctly. Not sure what a good quick fix would be for white text on orange background in dark theme, as exceptions are always annoying. Well, I guess we could hardcode it to a certain black lol, just don't tell tutti

EDIT: only just saw the resolved comment regarding Fix-banner-style 👍

image

@DanielSchiavini
Copy link
Collaborator

DanielSchiavini commented Nov 26, 2025

Alignment doesn't seem to work correctly. Not sure what a good quick fix would be for white text on orange background in dark theme, as exceptions are always annoying. Well, I guess we could hardcode it to a certain black lol, just don't tell tutti

It seems to just miss a justifyContent="center"

@0xPearce
Copy link
Collaborator Author

0xPearce commented Nov 26, 2025

Centered Banners for large screens.
Screenshot 2025-11-26 at 11 33 07

DanielSchiavini
DanielSchiavini previously approved these changes Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@DanielSchiavini DanielSchiavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, please check the design with Tutti though

0xtutti
0xtutti previously approved these changes Nov 26, 2025
View reviewed changes
@0xPearce
Copy link
Collaborator Author

0xPearce commented Nov 26, 2025

Waiting for new color variables #1696

@0xPearce 0xPearce marked this pull request as draft November 28, 2025 18:42
@0xPearce 0xPearce dismissed stale reviews from DanielSchiavini and 0xtutti via 5795718 December 3, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielSchiavini DanielSchiavini DanielSchiavini left review comments

@0xtutti 0xtutti 0xtutti left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@0xPearce @0xAlunara @DanielSchiavini @0xtutti