refactor: market advanced details parameters prework #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAlunara
requested review from
0xPearce,
0xtutti,
DanielSchiavini and
OnlyJousting
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
apps/main/src/llamalend/features/market-parameters/MarketMisc.tsx
Outdated
Show resolved
Hide resolved
apps/main/src/llamalend/features/market-parameters/MarketPrices.tsx
Outdated
Show resolved
Hide resolved
apps/main/src/llamalend/features/market-parameters/MarketParameters.tsx
Outdated
Show resolved
Hide resolved
apps/main/src/loan/components/PageLoanCreate/LoanFormCreate/index.tsx
Outdated
Show resolved
Hide resolved
0xtutti
previously approved these changes
Nov 27, 2025
0xAlunara
commented
Nov 27, 2025
0xAlunara
commented
Nov 27, 2025
DanielSchiavini
approved these changes
Nov 28, 2025
apps/main/src/llamalend/features/market-parameters/MarketLoanParameters.tsx
Show resolved
Hide resolved
0xPearce
approved these changes
Nov 28, 2025
OnlyJousting
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What started as me just wanting to add market id to the parameters, ended up in a bigger refactor where I consolidated and deduped the parameter section of the loan and lend market pages. In the Figma design it's hidden behind an 'Advanced Details' tab, but as a first step for now I've just consolidated it into a collection of action infos.
As a bonus / side-effect, the mint market (
loan) pages now have the same market parameters shown as lend markets.loanbefore:loanafter:lendbefore (borrow and supply tabs):lendafter (borrow and supply tabs):