-
Notifications
You must be signed in to change notification settings - Fork 44
feat: add pnl metric to /loan markets that has leverageV2 #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
68bb1f5
feat: add pnl metric to /loan markets that has leverageV2
OnlyJousting fecc528
refactor: update query comment
OnlyJousting 9b2e87f
Merge branch 'main' into feat/add-user-pnl-to-/loan
OnlyJousting e189bab
refactor: review comments
OnlyJousting File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import { enforce, group, test } from 'vest' | ||
| import { getLlamaMarket } from '@/llamalend/llama.utils' | ||
| import type { IChainId } from '@curvefi/api/lib/interfaces' | ||
| import { type FieldsOf } from '@ui-kit/lib' | ||
| import { type MarketQuery, queryFactory, rootKeys, type UserQuery } from '@ui-kit/lib/model' | ||
| import { loanExistsValidationGroup } from '@ui-kit/lib/model/query/loan-exists-validation' | ||
| import { marketIdValidationSuite } from '@ui-kit/lib/model/query/market-id-validation' | ||
| import { createValidationSuite } from '@ui-kit/lib/validation' | ||
| import { decimal } from '@ui-kit/utils' | ||
|
|
||
| /** | ||
| * Query for fetching user PNL data in lend and mint markets. | ||
| * PNL data from llamalend-js for mint markets is currently only available when v2 leverage is enabled. | ||
| */ | ||
| type UserPnlQuery = UserQuery & MarketQuery<IChainId> & { loanExists: boolean; hasV2Leverage: boolean } | ||
| type UserPnlParams = FieldsOf<UserPnlQuery> | ||
|
|
||
| export const { useQuery: useUserPnl, invalidate: invalidateUserPnl } = queryFactory({ | ||
| queryKey: ({ chainId, marketId, userAddress }: UserPnlParams) => | ||
| [...rootKeys.userMarket({ chainId, marketId, userAddress }), 'user-pnl'] as const, | ||
| queryFn: async ({ marketId, userAddress }: UserPnlQuery) => { | ||
| const market = getLlamaMarket(marketId) | ||
|
|
||
| const pnl = await market.currentPnL(userAddress) | ||
| return { | ||
| currentPosition: decimal(pnl?.currentPosition), | ||
| deposited: decimal(pnl?.deposited), | ||
| currentProfit: decimal(pnl?.currentProfit), | ||
| percentage: decimal(pnl?.percentage), | ||
| } | ||
| }, | ||
| staleTime: '1m', | ||
| validationSuite: createValidationSuite((params: UserPnlParams) => { | ||
| marketIdValidationSuite(params) | ||
| loanExistsValidationGroup(params) | ||
| group('hasV2LeverageValidation', () => { | ||
| test('hasV2Leverage', () => { | ||
| enforce(params.hasV2Leverage).isBoolean().equals(true) | ||
| }) | ||
| }) | ||
| }), | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.