-
Notifications
You must be signed in to change notification settings - Fork 44
test: add e2e tests for loan and lend market page #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xAlunara
commented
Nov 27, 2025
packages/curve-ui-kit/src/features/connect-wallet/lib/wagmi/useWagmiConfig.ts
Show resolved
Hide resolved
0xAlunara
commented
Nov 27, 2025
packages/curve-ui-kit/src/features/connect-wallet/lib/wagmi/useWagmiConfig.ts
Show resolved
Hide resolved
…ing the first element of an array
0xAlunara
commented
Nov 28, 2025
0xAlunara
commented
Nov 28, 2025
packages/curve-ui-kit/src/features/connect-wallet/lib/wagmi/useWagmiConfig.ts
Show resolved
Hide resolved
b7e51eb to
0257ce2
Compare
0257ce2 to
4e2d442
Compare
DanielSchiavini
approved these changes
Nov 28, 2025
packages/curve-ui-kit/src/features/connect-wallet/lib/wagmi/useWagmiConfig.ts
Show resolved
Hide resolved
packages/curve-ui-kit/src/features/connect-wallet/lib/wagmi/useWagmiConfig.ts
Show resolved
Hide resolved
0xPearce
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to shuffle some wagmi test and test connector code into
ui-kit, because e2e tests are run on app code directly.The tenderly specific wagmi config with tenderly specific connector however remain in the
testsproject. Don't want to clog the apps with that.Two tests are added that basically open a lend / loan market page for some random wallet, and it expects no uncaught errors like we've encountered before.
I did not bother yet with custom private RPCs in case of rate limiting. For now the public dRPC seems to work fine.