Permalink
Browse files

ffmpeg: complain loudly and exit in case removed -sameq option is spe…

…cified

This is better than silently ignoring the option, which results in
unexpected quality results.
  • Loading branch information...
1 parent c9eaa98 commit a62242678ff96eade59960d1bbf65e4f3f03344f @saste saste committed Nov 2, 2012
Showing with 5 additions and 2 deletions.
  1. +5 −2 ffmpeg_opt.c
View
@@ -159,8 +159,11 @@ static int opt_pad(void *optctx, const char *opt, const char *arg)
static int opt_sameq(void *optctx, const char *opt, const char *arg)
{
- av_log(NULL, AV_LOG_WARNING, "Ignoring option '%s'\n", opt);
- return 0;
+ av_log(NULL, AV_LOG_ERROR, "Option '%s' was removed. "
+ "If you are looking for an option to preserve the quality (which is not "
+ "what -%s was for), use -qscale 0 or an equivalent quality factor option.\n",
+ opt, opt);
+ return AVERROR(EINVAL);
}
static int opt_video_channel(void *optctx, const char *opt, const char *arg)

0 comments on commit a622426

Please sign in to comment.