Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

ci: changes Slack deployment message channel #60

Closed
wants to merge 2 commits into from

Conversation

matt-frizzell
Copy link

Changes the Slack channel for deployment messages to the new mobile-deployments channel

See customerio/issues#9014

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After pull request is approved, and you determine it's ready add the label "Ready to merge" to the pull request and it will automatically be merged.

Changes the Slack channel for deployment messages to the new mobile-deployments channel

See customerio/issues#9014
@matt-frizzell matt-frizzell requested review from levibostian and a team January 9, 2023 02:56
@matt-frizzell matt-frizzell self-assigned this Jan 9, 2023
@ami-oss-ci
Copy link

ami-oss-ci commented Jan 9, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@matt-frizzell matt-frizzell added the blocked Cannot work on task for some reason label Jan 11, 2023
@levibostian levibostian changed the base branch from develop to main February 13, 2023 14:55
@levibostian
Copy link
Member

Updated base branch from develop to main because we are deleting the develop branch.

Since main and develop both have the same branches in them, the file changes in this PR are the same after updating the base branch.

@levibostian
Copy link
Member

I don't see much value in having slack deployment messages for RH app. Also because we are deprecating the app, I think it's better for us to disable slack messages instead of trying to modify them.

Closing. Re-open if someone believes this still adds value.

@levibostian levibostian deleted the ci-9014-slack-mobile-deployment branch September 11, 2023 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked Cannot work on task for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants