Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syzygy adjudications: add 7man and 5x speedup #554

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wakamex
Copy link

@wakamex wakamex commented Jan 15, 2020

switched to latest tbprobe library Fathom care of @jdart1.

switched cutechess to query using a different API call tb_probe_wdl which is the thread safe function recommended for engines as per the Fathom readme. engines may care about DTZ, but for adjudication only WDL is necessary.

there may be some quirks in completely ignoring DTZ, such as scoring a win/loss that takes longer than 50 moves. could add a check to add in DTZ if they're found, maybe, but that would require enhancing the api to return the number of files found. right now it just returns a success or fail at initiation.

@artoj
Copy link
Member

artoj commented May 16, 2020

The Windows CI failed with this patch. Can you review the build output and submit an update. Thanks!

@jdart1
Copy link

jdart1 commented May 16, 2020

I think you need to add /Tp to the Windows flags to force compilation of tbprobe.c as a C++ file (Fathom requires compilation under C99 or C++).

@ilaripih
Copy link
Member

I think you need to add /Tp to the Windows flags to force compilation of tbprobe.c as a C++ file (Fathom requires compilation under C99 or C++).

I tried that and now I get a bunch of warnings about unsafe functions and an error:
3rdparty\fathom\src\tbprobe.c(305): error C2664: 'HANDLE CreateFileW(LPCWSTR,DWORD,DWORD,LPSECURITY_ATTRIBUTES,DWORD,DWORD,HANDLE)': cannot convert argument 1 from 'char *' to 'LPCWSTR'

https://ci.appveyor.com/project/artoj/cutechess/builds/33803803

@jdart1
Copy link

jdart1 commented Jul 5, 2020

See wakamex#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants