Interactivity problem with Leaflet in Chrome Canary #242

Closed
alperdincer opened this Issue Jul 24, 2012 · 14 comments

Comments

Projects
None yet
6 participants
@alperdincer

Hi,

I'm using Chrome Canary (22.0.1215.1) for development and I released that wax and leaflet don't work together on this browser.

You can check documentation page (http://mapbox.com/wax/interaction-leaf.html) on Chrome Canary to see what's going on.

Alper.

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Jul 24, 2012

Can you see the problem in Chrome release cycle? This appears to work for me in Chrome Beta, and I'd rather not fix pre-release bugs in Chrome, of which there are many.

tmcw commented Jul 24, 2012

Can you see the problem in Chrome release cycle? This appears to work for me in Chrome Beta, and I'd rather not fix pre-release bugs in Chrome, of which there are many.

@alperdincer

This comment has been minimized.

Show comment Hide comment
@alperdincer

alperdincer Jul 24, 2012

There is no problem with Chrome Beta (version 21.0.1180.49 beta)

I just want to inform you about the issue.

Thanks a lot.

There is no problem with Chrome Beta (version 21.0.1180.49 beta)

I just want to inform you about the issue.

Thanks a lot.

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Jul 24, 2012

Thanks, hopefully Google catches it before it lands :)

tmcw commented Jul 24, 2012

Thanks, hopefully Google catches it before it lands :)

@dooley

This comment has been minimized.

Show comment Hide comment
@dooley

dooley Sep 27, 2012

Unfortunatly not, Chrome Version 22.0.1229.79 (Win7) as well as latest stable version on Ubuntu has the problem from above. Any workaround?

dooley commented Sep 27, 2012

Unfortunatly not, Chrome Version 22.0.1229.79 (Win7) as well as latest stable version on Ubuntu has the problem from above. Any workaround?

@javierarce

This comment has been minimized.

Show comment Hide comment
@javierarce

javierarce Sep 28, 2012

Same thing in Chrome for mac. I'm currently using Chrome 22.0.1229.91 beta, but there are problems in the stable channel too.

Same thing in Chrome for mac. I'm currently using Chrome 22.0.1229.91 beta, but there are problems in the stable channel too.

@javisantana

This comment has been minimized.

Show comment Hide comment
@javisantana

javisantana Sep 28, 2012

the problem is with wax.offset, if you use $(el).offset return different values.

A quick fix (not tested in IE)

CartoDB/wax@08b8247

the problem is with wax.offset, if you use $(el).offset return different values.

A quick fix (not tested in IE)

CartoDB/wax@08b8247

@dooley

This comment has been minimized.

Show comment Hide comment
@dooley

dooley Sep 28, 2012

@ javisantana: Great, works without sideeffect in Chrome, Firefox, IE on Win7 (latest versions). Thanks for that!

dooley commented Sep 28, 2012

@ javisantana: Great, works without sideeffect in Chrome, Firefox, IE on Win7 (latest versions). Thanks for that!

@javisantana

This comment has been minimized.

Show comment Hide comment
@javisantana

javisantana Sep 28, 2012

@dooley thanks for testing.

also that fix solves some problems wax had with fixed positions on elements in the html page.

we have some testing for libraries that use wax, maybe is a good idea to "backport" them to wax to test this kind of things on different browser/OS/devices

@dooley thanks for testing.

also that fix solves some problems wax had with fixed positions on elements in the html page.

we have some testing for libraries that use wax, maybe is a good idea to "backport" them to wax to test this kind of things on different browser/OS/devices

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Oct 1, 2012

@javisantana can you provide this as a pull request?

tmcw commented Oct 1, 2012

@javisantana can you provide this as a pull request?

@javisantana

This comment has been minimized.

Show comment Hide comment
@javisantana

javisantana Oct 1, 2012

done

done

tmcw pushed a commit that referenced this issue Oct 3, 2012

tmcw added a commit that referenced this issue Oct 3, 2012

Merge pull request #258 from CartoDB/offset_bug
attemp to fix #242 (wax broken in chrome 22)
@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Oct 3, 2012

Pull request merged.

tmcw commented Oct 3, 2012

Pull request merged.

@tmcw tmcw reopened this Oct 3, 2012

@miketahani

This comment has been minimized.

Show comment Hide comment
@miketahani

miketahani Nov 6, 2012

Fix worked for me, but it looks like the changes haven't made their way into dist/ on master. Thanks!

Fix worked for me, but it looks like the changes haven't made their way into dist/ on master. Thanks!

@javisantana

This comment has been minimized.

Show comment Hide comment
@javisantana

javisantana Nov 6, 2012

we have been using it extensively past months without any problem, i consider it fixed

we have been using it extensively past months without any problem, i consider it fixed

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Nov 6, 2012

Rebuilt and pushed in 1424765

tmcw commented Nov 6, 2012

Rebuilt and pushed in 1424765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment