working on three dialog translation

[AlexVCS]

Issue number

#629

• Working to Resolve [Feature]: Apply translation/localization to all text in the ThreeDialog #629

Please check the following

• [✅ ] Do the tests still pass? (see Run the Tests)
• Is the code formatted properly? (see Linting (Formatting))
• For New Features:
  • Have tests been added to cover any new features or fixes?
  • Has the documentation been updated accordingly?

Please describe additional details for testing this change

I want to look at what I've added but am not sure where to access it. I'll have to find out where it lives and check that it works as intended.

[AlexVCS]

Any feedback on this? I'm not sure why the e2e install isn't working correctly

[itsalaidbacklife]

Any feedback on this? I'm not sure why the e2e install isn't working correctly

It looks like cypress is failing to parse the json in the en.json file, likely due to a syntax error

[AlexVCS]

Do I need to rebase? I keep getting this when I try to push the right changes and I pulled in the latest changes I think:

! [rejected] ThreeDialog-translation -> ThreeDialog-translation (non-fast-forward)
error: failed to push some refs to 'https://github.com/AlexVCS/cuttle.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

[AlexVCS]

My branches say up to date when I do
git pull https://github.com/cuttle-cards/cuttle.git main

[itsalaidbacklife]

@AlexVCS that indicates that you need to git pull. It's possible that your previous pull was rejected due to local changes that aren't pushed yet. So you could try resolving this with git pull --rebase before pushing.

If you're unable to pull with a rebase, we can hash out the details of the git error in discord

[itsalaidbacklife]

Nice work. Thanks for your contribution!