Improve social authentication #5349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/check |
|
❌ Some checks failed |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Marishka17
changed the title
Marishka17
force-pushed
the
mk/improve_social_authentication
branch
from
231ee10
to
e39850b
Compare
Marishka17
changed the title
|
/check |
|
✔️ All checks completed successfully |
Marishka17
changed the title
nmanovic
reviewed
Nov 27, 2022
| }, | ||
| }; | ||
| cvat.server.request( | ||
| `${cvat.config.backendAPI}/auth/${provider}/login/token?state=${state}`, req, |
There was a problem hiding this comment.
@Marishka17 , should it be a part of cvat-core?
There was a problem hiding this comment.
Do you mean dedicated API method like loginSocial?
nmanovic
reviewed
Nov 27, 2022
nmanovic
requested changes
Nov 27, 2022
There was a problem hiding this comment.
@Marishka17 , it looks good from my perspective at least. Need to slightly change the code. Also I expect to see all these auth methods in our swagger. What is a reason to hide them?
bsekachev
reviewed
Nov 28, 2022
cvat-ui/src/components/login-with-social-app/login-with-social-app.tsx
Outdated
Show resolved
Hide resolved
| }, | ||
| }; | ||
| cvat.server.request( | ||
| `${cvat.config.backendAPI}/auth/${provider}/login/token?state=${state}`, req, |
There was a problem hiding this comment.
Do you mean dedicated API method like loginSocial?
cvat-ui/src/components/login-with-social-app/login-with-social-app.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/login-with-social-app/login-with-social-app.tsx
Outdated
Show resolved
Hide resolved
6 tasks
nmanovic
approved these changes
Dec 10, 2022
nmanovic
pushed a commit
that referenced
this pull request
Jan 12, 2023
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
Depends on cvat-ai#5349 Related cvat-ai#5432 Added tests for social account authentication functionality: cypress test with dummy auth server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
In another PR
Checklist
developbranch- [ ] I have added a description of my changes into CHANGELOG file- [ ] I have updated the documentation accordingly- [ ] I have linked related issues (read github docs)cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.