Tarball Ingestion #2097
Closed
Tarball Ingestion #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume that #2098 requires some adjustments for this PR, too, so you might want to resubmit after rebasing. |
|
👍 It could definitely. |
|
We rebase on #2101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the new functionality of tarball ingestion.
It is mostly ready and at least big errors are found the main architecture will stay this one.
Being this a quite big PR any suggestion to split it in more manageable chunk is very welcome.
Moreover, if any helps is needed in the code review phase in the form of documentation or addition of comments or any other write up I am happy to oblige.
Still I would like to check some details especially on the SyncItem class where I changed the visibility of some fields. Nevertheless I would like to have travis running on this.
Also the last additions makes quite difficult to have a solid unittest suite, that for the moment is commented out.
I do need some time to think about the best way to provide unittest for this PR.