Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
sake92
added some commits
Dec 3, 2017
This comment has been minimized.
This comment has been minimized.
CLAassistant
commented
Dec 31, 2017
•
|
|
sake92
added some commits
Dec 31, 2017
| // when replacing the path with \ Java treats it like escape character, | ||
| // that's why we need Matcher.quoteReplacement | ||
| return pathWithSlashes.replaceAll("/", Matcher.quoteReplacement(File.separator)); | ||
| } | ||
| } |
This comment has been minimized.
This comment has been minimized.
cvogt
Dec 31, 2017
Owner
This file is auto-generated ( see comment in top line ). Editing it by hand is not the way to go.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sake92
Jan 1, 2018
Contributor
How about this solution?
Btw, when I do cbt tools cbtEarlyDependencies it generates the file in cbt/nailgun_launcher and not in cbt/nailgun_launcher/src/cbt.. Is that expected?
This comment has been minimized.
This comment has been minimized.
sake92
added some commits
Dec 31, 2017
This comment has been minimized.
This comment has been minimized.
|
great stuff :) |
cvogt
merged commit 3fbf948
into
cvogt:master
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sake92 commentedDec 31, 2017
This PR fixes most of the issues with using CBT on Windows:
pip(unixPath: String)(path-independent-path, just converts slashes to backslashes)Some minor issues left:
java.net.SocketException: Connection reset.. >> %nailgun_out% 2>> %nailgun_err%)evalcan't be used with single-quotes since CMD treats them specially... You can use double-quotes but then you can't useStringliterals