-
Notifications
You must be signed in to change notification settings - Fork 59
Windows script fix #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows script fix #577
Conversation
- removed using temp file - made helper functions (like in bash script)
- cleaned batch script, capitalized CMD commands
// when replacing the path with \ Java treats it like escape character, | ||
// that's why we need Matcher.quoteReplacement | ||
return pathWithSlashes.replaceAll("/", Matcher.quoteReplacement(File.separator)); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is auto-generated ( see comment in top line ). Editing it by hand is not the way to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't see that. :/ Guess I'll have to find another way..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this solution?
Btw, when I do cbt tools cbtEarlyDependencies
it generates the file in cbt/nailgun_launcher
and not in cbt/nailgun_launcher/src/cbt
.. Is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a bug
great stuff :) |
This PR fixes most of the issues with using CBT on Windows:
pip(unixPath: String)
(path-independent-path, just converts slashes to backslashes)Some minor issues left:
java.net.SocketException: Connection reset
.. >> %nailgun_out% 2>> %nailgun_err%
)eval
can't be used with single-quotes since CMD treats them specially... You can use double-quotes but then you can't useString
literals 😄