Windows script fix #577
Merged
Windows script fix #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed using temp file - made helper functions (like in bash script)
- cleaned batch script, capitalized CMD commands
|
|
cvogt
reviewed
Dec 31, 2017
| // when replacing the path with \ Java treats it like escape character, | ||
| // that's why we need Matcher.quoteReplacement | ||
| return pathWithSlashes.replaceAll("/", Matcher.quoteReplacement(File.separator)); | ||
| } | ||
| } |
There was a problem hiding this comment.
This file is auto-generated ( see comment in top line ). Editing it by hand is not the way to go.
There was a problem hiding this comment.
Oh, I didn't see that. :/ Guess I'll have to find another way..
There was a problem hiding this comment.
How about this solution?
Btw, when I do cbt tools cbtEarlyDependencies it generates the file in cbt/nailgun_launcher and not in cbt/nailgun_launcher/src/cbt.. Is that expected?
|
great stuff :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes most of the issues with using CBT on Windows:
pip(unixPath: String)(path-independent-path, just converts slashes to backslashes)Some minor issues left:
java.net.SocketException: Connection reset.. >> %nailgun_out% 2>> %nailgun_err%)evalcan't be used with single-quotes since CMD treats them specially... You can use double-quotes but then you can't useStringliterals 😄