From eaf8bd1d468f7b566509ab63b7565a6204f26914 Mon Sep 17 00:00:00 2001 From: "Paul J. Adam" Date: Wed, 19 Nov 2025 17:58:03 -0600 Subject: [PATCH 1/5] Update SwiftLintView.swift --- .../iOSswiftUIa11yTechniques/SwiftLintView.swift | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/iOSswiftUIa11yTechniques/iOSswiftUIa11yTechniques/SwiftLintView.swift b/iOSswiftUIa11yTechniques/iOSswiftUIa11yTechniques/SwiftLintView.swift index dbf8da6..e3aa0dd 100644 --- a/iOSswiftUIa11yTechniques/iOSswiftUIa11yTechniques/SwiftLintView.swift +++ b/iOSswiftUIa11yTechniques/iOSswiftUIa11yTechniques/SwiftLintView.swift @@ -25,7 +25,7 @@ struct SwiftLintView: View { var body: some View { ScrollView { VStack { - Text("Scroll views are not scrollable with Full Keyboard Access unless there is a focusable control like a `Button` or `DisclosureGroup` inside or after the scroll view.") + Text("Swift Lint ... .") .padding(.bottom) Text("Good Examples") .font(.subheadline) @@ -50,7 +50,7 @@ struct SwiftLintView: View { .accessibilityIdentifier("goodImage") DisclosureGroup("Details") { Text("The good example has an `.accessibilityLabel` set on it.") - }.padding(.bottom) + }.padding(.bottom).accessibilityHint("Good Example") Text("Bad Examples") .font(.subheadline) .fontWeight(.bold) @@ -71,6 +71,10 @@ struct SwiftLintView: View { .aspectRatio(contentMode: .fit) .frame(width: 100, height: 100) .accessibilityIdentifier("badImage") + DisclosureGroup("Details") { + Text("The bad example has no single tap alternatives to move or zoom the map.") + }.accessibilityHint("Bad Example") + } .navigationTitle("Swift Lint") .padding() From 7ea652bba538521633ae96fa9cb52abf83b88fcb Mon Sep 17 00:00:00 2001 From: "Paul J. Adam" Date: Wed, 19 Nov 2025 18:02:01 -0600 Subject: [PATCH 2/5] Update SwiftLint action version and job name --- .github/workflows/swiftlint.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/swiftlint.yml b/.github/workflows/swiftlint.yml index 79d8581..f2396a6 100644 --- a/.github/workflows/swiftlint.yml +++ b/.github/workflows/swiftlint.yml @@ -4,13 +4,13 @@ on: pull_request: jobs: - swiftlint: + lint: runs-on: macos-latest steps: - uses: actions/checkout@v4 - - name: Run SwiftLint with Annotations - uses: norio-nomura/action-swiftlint@v4 + - name: Run SwiftLint with annotations + uses: norio-nomura/action-swiftlint@v3.2.1 with: strict: true From 1db68953d895b5cabd2b396fea64c4d89b9260a3 Mon Sep 17 00:00:00 2001 From: "Paul J. Adam" Date: Wed, 19 Nov 2025 18:04:05 -0600 Subject: [PATCH 3/5] Update SwiftLint action version to 3.2.1 --- .github/workflows/swiftlint.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/swiftlint.yml b/.github/workflows/swiftlint.yml index f2396a6..5a44bdf 100644 --- a/.github/workflows/swiftlint.yml +++ b/.github/workflows/swiftlint.yml @@ -11,6 +11,7 @@ jobs: - uses: actions/checkout@v4 - name: Run SwiftLint with annotations - uses: norio-nomura/action-swiftlint@v3.2.1 + uses: norio-nomura/action-swiftlint@3.2.1 with: strict: true + From 9a550f3c1b9e5fdf1ad9fb766e43e474ad0d14f2 Mon Sep 17 00:00:00 2001 From: "Paul J. Adam" Date: Wed, 19 Nov 2025 18:05:34 -0600 Subject: [PATCH 4/5] Update SwiftLint workflow to install and annotate errors --- .github/workflows/swiftlint.yml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/swiftlint.yml b/.github/workflows/swiftlint.yml index 5a44bdf..26c7eb2 100644 --- a/.github/workflows/swiftlint.yml +++ b/.github/workflows/swiftlint.yml @@ -10,8 +10,12 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Run SwiftLint with annotations - uses: norio-nomura/action-swiftlint@3.2.1 - with: - strict: true + - name: Install SwiftLint + run: brew install swiftlint + - name: Annotate SwiftLint errors in PR + uses: reviewdog/action-swiftlint@v1 + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + reporter: github-pr-review + fail_on_error: true From 7e9bbd1797c2e1f87f76c7c022d1fadbc50ff9bf Mon Sep 17 00:00:00 2001 From: "Paul J. Adam" Date: Wed, 19 Nov 2025 18:07:06 -0600 Subject: [PATCH 5/5] Update SwiftLint GitHub Actions workflow Removed reviewdog action and added a direct SwiftLint run step. --- .github/workflows/swiftlint.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/swiftlint.yml b/.github/workflows/swiftlint.yml index 26c7eb2..2ff9beb 100644 --- a/.github/workflows/swiftlint.yml +++ b/.github/workflows/swiftlint.yml @@ -8,14 +8,11 @@ jobs: runs-on: macos-latest steps: - - uses: actions/checkout@v4 + - name: Checkout + uses: actions/checkout@v4 - name: Install SwiftLint run: brew install swiftlint - - name: Annotate SwiftLint errors in PR - uses: reviewdog/action-swiftlint@v1 - with: - github_token: ${{ secrets.GITHUB_TOKEN }} - reporter: github-pr-review - fail_on_error: true + - name: Run SwiftLint + run: swiftlint --strict