Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Constant #28

Closed
bnaras opened this issue Apr 5, 2018 · 1 comment
Closed

Bug in Constant #28

bnaras opened this issue Apr 5, 2018 · 1 comment

Comments

@bnaras
Copy link
Collaborator

@bnaras bnaras commented Apr 5, 2018

A rounding error in constant.

> Constant((2/632)^2)
Constant(CONSTANT, POSITIVE, (1,1))> 
> Constant((2/633)^2)
Constant(CONSTANT, ZERO, (1,1))> 
@bnaras
Copy link
Collaborator Author

@bnaras bnaras commented Apr 6, 2018

Ok, this is actually a bug in intf_sign (in interface.R). For some reason, tol is a parameter. It is not needed and the check can be done against zero. I'll commit soon.

@bnaras bnaras closed this Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.