-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up tests to use FactCheck #47
Conversation
Few issues:
|
@davidlizeng I think this is ready to merge into master. Coverage should go up another 20% after we test with SCS on travis, after which most of the uncovered lines are error checks, etc. of lower priority. |
@@ -1,3 +1,4 @@ | |||
julia 0.3 | |||
MathProgBase 0.3.8 | |||
ECOS 0.4.1 | |||
FactCheck 0.2.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is usually listed in test/REQUIRE
since it's only needed to run tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the nicest way for FactCheck to still be present for travis?
JuMP seems to be doing this: https://github.com/JuliaOpt/JuMP.jl/blob/master/.travis.yml#L11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I guess we never tidied that up. @IainNZ
If you just use Pkg.test("Convex", coverage=true)
then first the testing dependencies will be installed and then test/runtests.jl
will be run. That's the "right" way to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks! I'm going to keep this PR open for another few days to see if anyone has other feedback, and merge it then.
clean up tests to use FactCheck
Reorganized test.jl and test2.jl into affine, lp, and socp test files as per #42 .
All tests also now use the FactCheck package.