Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: retrieve mip gap from SCIPY solution" #2111

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

SteveDiamond
Copy link
Collaborator

This reverts commit 6eb5466.

Description

The MIP gap is not available with the interface we are using. Consequently the added tests fail. We didn't notice the regression because of unrelated failures in the CI.

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

@github-actions
Copy link

Benchmarks that have stayed the same:

   before           after         ratio
 [ee17c403]       [f9fa86d0]
      45.9±0s          46.9±0s     1.02  sdp_segfault_1132_benchmark.SDPSegfault1132Benchmark.time_compile_problem
      30.0±0s          30.3±0s     1.01  cvar_benchmark.CVaRBenchmark.time_compile_problem
      8.47±0s          8.49±0s     1.00  optimal_advertising.OptimalAdvertising.time_compile_problem
      9.53±0s          9.53±0s     1.00  huber_regression.HuberRegression.time_compile_problem
      24.1±0s          24.1±0s     1.00  simple_LP_benchmarks.SimpleLPBenchmark.time_compile_problem
      8.72±0s          8.71±0s     1.00  semidefinite_programming.SemidefiniteProgramming.time_compile_problem
      4.12±0s          4.11±0s     1.00  simple_LP_benchmarks.SimpleFullyParametrizedLPBenchmark.time_compile_problem
      11.2±0s          11.2±0s     0.99  svm_l1_regularization.SVMWithL1Regularization.time_compile_problem
      1.87±0s          1.84±0s     0.98  simple_LP_benchmarks.SimpleScalarParametrizedLPBenchmark.time_compile_problem

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@SteveDiamond SteveDiamond merged commit 7420ba3 into master Apr 25, 2023
@SteveDiamond SteveDiamond deleted the steven-revert-mip-gap branch April 25, 2023 23:40
phschiele added a commit that referenced this pull request Apr 26, 2023
phschiele added a commit that referenced this pull request May 1, 2023
* Revert "Revert "feat: retrieve mip gap from SCIPY solution (#2103)" (#2111)"

This reverts commit 7420ba3.

* Uses milp instead of linprog

* Same time limit as before
@phschiele phschiele mentioned this pull request Jun 22, 2023
@phschiele phschiele mentioned this pull request Jul 29, 2023
@Paulnkk Paulnkk mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant