Fix import netscape #3

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@ricardosdl
Contributor

ricardosdl commented Dec 12, 2012

I was having problems importing my bookmarks exported from delicious. I've made some adjustments and now it's working. Maybe you want to check my changes. Comments and opinions are welcome.

@ricardosdl

This comment has been minimized.

Show comment Hide comment
@ricardosdl

ricardosdl Dec 16, 2012

Contributor

I think I've found the problem with the failed test in https://travis-ci.org/cweiske/SemanticScuttle/builds/3620673

The InnoDB storage engine of Mysql apparently makes the test fail. I've run the tests using InnoDB and MyISAM on Mysql versions 5.1 and 5.5(where the default engine now is InnoDB).

The assertion seems to check the order of bookmarks returned from getBookmarks(). I get different orders with MyIsam and InnoDB. Apparently the clause used to order the bookmarks is bModified DESC. The test is fast enough to insert the bookmarks in the same second. Putting a call to sleep(1) between the creation of bookmark 2 and bookmark 3 makes the test pass, but I don't know if this is the right thing to do.

Contributor

ricardosdl commented Dec 16, 2012

I think I've found the problem with the failed test in https://travis-ci.org/cweiske/SemanticScuttle/builds/3620673

The InnoDB storage engine of Mysql apparently makes the test fail. I've run the tests using InnoDB and MyISAM on Mysql versions 5.1 and 5.5(where the default engine now is InnoDB).

The assertion seems to check the order of bookmarks returned from getBookmarks(). I get different orders with MyIsam and InnoDB. Apparently the clause used to order the bookmarks is bModified DESC. The test is fast enough to insert the bookmarks in the same second. Putting a call to sleep(1) between the creation of bookmark 2 and bookmark 3 makes the test pass, but I don't know if this is the right thing to do.

@cweiske

This comment has been minimized.

Show comment Hide comment
@cweiske

cweiske Mar 21, 2013

Owner

Thanks for your patches. I've merged the ones that were not already fixed in the meantime (didn't remember your pull request until after the release of 0.98.5, sorry).

Some notes for the future:

  • You can use git commit --amend to change the commit message afterwards if you made typos
  • Delete trailing whitespaces when saving files; some patches had empty lines with spaces only in them
  • PEAR packages can be installed without giving a version; i've adjusted the readme accordingly
Owner

cweiske commented Mar 21, 2013

Thanks for your patches. I've merged the ones that were not already fixed in the meantime (didn't remember your pull request until after the release of 0.98.5, sorry).

Some notes for the future:

  • You can use git commit --amend to change the commit message afterwards if you made typos
  • Delete trailing whitespaces when saving files; some patches had empty lines with spaces only in them
  • PEAR packages can be installed without giving a version; i've adjusted the readme accordingly

@cweiske cweiske closed this Mar 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment