URI::Encode-0.08 breaks tests #1

Closed
cwimmer opened this Issue Oct 20, 2012 · 1 comment

Comments

Projects
None yet
1 participant
Owner

cwimmer commented Oct 20, 2012

dartagnan:Net-Amazon-SignatureVersion4 cwimmer$ dzil test
[DZ] building distribution under .build/NG1LqBVAI0 for installation
[DZ] beginning to build Net-Amazon-SignatureVersion4
[DZ] guessing dist's main_module is lib/Net/Amazon/SignatureVersion4.pm
[DZ] extracting distribution abstract from lib/Net/Amazon/SignatureVersion4.pm
[@Basic/ExtraTests] rewriting author test xt/author/critic.t
[@Basic/ExtraTests] rewriting release test xt/release/pod-coverage.t
[@Basic/ExtraTests] rewriting release test xt/release/pod-syntax.t
[PodVersion] lib/Net/Amazon/SignatureVersion4.pm already has a VERSION section in POD
[DZ] writing Net-Amazon-SignatureVersion4 in .build/NG1LqBVAI0
Checking if your kit is complete...
Looks good
Writing Makefile for Net::Amazon::SignatureVersion4
Writing MYMETA.yml and MYMETA.json
cp lib/Net/Amazon/SignatureVersion4.pm blib/lib/Net/Amazon/SignatureVersion4.pm
Manifying blib/man3/Net::Amazon::SignatureVersion4.3
PERL_DL_NONLAZY=1 /Users/cwimmer/perl5/perlbrew/perls/perl-5.16.1/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/01-aws4_testsuite.t ....... 1/? 
#   Failed test 'post-vanilla-query-nonunreserved Canonical Request'
#   at t/01-aws4_testsuite.t line 38.

#   Failed test 'post-vanilla-query-nonunreserved String to Sign'
#   at t/01-aws4_testsuite.t line 43.

#   Failed test 'post-vanilla-query-nonunreserved Authorization'
#   at t/01-aws4_testsuite.t line 48.
# DIFF: Authorization: AWS4-HMAC-SHA256 Credential=AKIDEXAMPLE/20110909/us-east-1/host/aws4_request, SignedHeaders=date;host, Signature=28675d93ac1d686ab9988d6617661da4dffe7ba848a2285cb75eac6512e861f9
# DIFF: Authorization: AWS4-HMAC-SHA256 Credential=AKIDEXAMPLE/20110909/us-east-1/host/aws4_request, SignedHeaders=date;host, Signature=663632cd1e460167b23040e016e56c8da99cfcbe4f72362b9eaf9adbb3ad2a87

#   Failed test 'post-vanilla-query-nonunreserved Signed Request'
#   at t/01-aws4_testsuite.t line 58.

#   Failed test 'get-vanilla-ut8-query Canonical Request'
#   at t/01-aws4_testsuite.t line 38.

#   Failed test 'get-vanilla-ut8-query String to Sign'
#   at t/01-aws4_testsuite.t line 43.

#   Failed test 'get-vanilla-ut8-query Authorization'
#   at t/01-aws4_testsuite.t line 48.
# DIFF: Authorization: AWS4-HMAC-SHA256 Credential=AKIDEXAMPLE/20110909/us-east-1/host/aws4_request, SignedHeaders=date;host, Signature=5a9f1bad3fccc96d57f592cb86fdb578fd93479a36e8f1d85c851fb1ddac824f
# DIFF: Authorization: AWS4-HMAC-SHA256 Credential=AKIDEXAMPLE/20110909/us-east-1/host/aws4_request, SignedHeaders=date;host, Signature=6fb359e9a05394cc7074e0feb42573a2601abc0c869a953e8c5c12e4e01f1a8c

#   Failed test 'get-vanilla-ut8-query Signed Request'
#   at t/01-aws4_testsuite.t line 58.
# Looks like you failed 8 tests of 120.
t/01-aws4_testsuite.t ....... Dubious, test returned 8 (wstat 2048, 0x800)
Failed 8/120 subtests 
t/02-derived-signing-key.t .. ok   
t/03_real_world_test.t ...... ok   
t/author-critic.t ........... ok   
t/release-pod-coverage.t .... skipped: these tests are for release candidate testing
t/release-pod-syntax.t ...... skipped: these tests are for release candidate testing

Test Summary Report
-------------------
t/01-aws4_testsuite.t     (Wstat: 2048 Tests: 120 Failed: 8)
  Failed tests:  21-24, 45-48
  Non-zero exit status: 8
Files=6, Tests=127,  3 wallclock secs ( 0.06 usr  0.01 sys +  3.38 cusr  0.20 csys =  3.65 CPU)
Result: FAIL
Failed 1/6 test programs. 8/127 subtests failed.
make: *** [test_dynamic] Error 255
error running make test

@ghost ghost assigned cwimmer Oct 20, 2012

Owner

cwimmer commented Oct 21, 2012

The problem was changes made in URI::Encode version 0.08. We now explicitly set the desired behavior of URI::Encode. This is fixed in version 0.006 of this module.

@cwimmer cwimmer closed this Oct 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment