Missing split string setup fix #13

Merged
merged 2 commits into from Oct 19, 2011

Conversation

Projects
None yet
2 participants
Contributor

bgipsy commented Oct 19, 2011

SharedStringTable calls split_string_setup which isn't accessible from its context. Big enough block_length is needed to trigger the bug.

Please find quick fix with test case in my branch. I was considering an alternative change, which is pulling split_string_setup out of workbook.rb into helper.rb, but diverged from that. Wanted to keep global namespace from extra pollution.

Let me know if changes make sense.

Thanks!

@cxn03651 cxn03651 merged commit 0452d85 into cxn03651:master Oct 19, 2011

Owner

cxn03651 commented Oct 19, 2011

yes, it's bug. I've merged your patch and released new gem.

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment