Skip to content

Commit

Permalink
properly pass options when fields_for is called with colletion
Browse files Browse the repository at this point in the history
Closes ryanb#214
  • Loading branch information
lest committed Nov 5, 2012
1 parent bd30e0b commit f08415f
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
9 changes: 5 additions & 4 deletions lib/nested_form/builder_mixin.rb
Expand Up @@ -75,10 +75,11 @@ def fields_for_with_nested_attributes(association_name, *args)
# TODO Test this better
block = args.pop || Proc.new { |fields| @template.render(:partial => "#{association_name.to_s.singularize}_fields", :locals => {:f => fields}) }

options = if args[0].kind_of? Array # Rails 3.0.x
args[0].dup.extract_options!
else
args.dup.extract_options!
options = args.dup.extract_options!

# Rails 3.0.x
if options.empty? && args[0].kind_of?(Array)
options = args[0].dup.extract_options!
end

@fields ||= {}
Expand Down
12 changes: 12 additions & 0 deletions spec/nested_form/builder_spec.rb
Expand Up @@ -126,6 +126,18 @@

output.should match(/div.+data-blueprint="Task"/)
end

it "doesn't render wrapper div when collection is passed" do
task = project.tasks.build
fields = subject.fields_for(:tasks, project.tasks, :wrapper => false) { 'Task' }

fields.should eq('Task')

subject.link_to_add 'Add', :tasks
output = template.send(:after_nested_form_callbacks)

output.should match(/div.+data-blueprint="Task"/)
end
end

context "with options" do
Expand Down

0 comments on commit f08415f

Please sign in to comment.