Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces are encoded correctly in variable IDs #72

Closed
orenbm opened this issue Jun 8, 2020 · 0 comments · Fixed by #71
Closed

Spaces are encoded correctly in variable IDs #72

orenbm opened this issue Jun 8, 2020 · 0 comments · Fixed by #71

Comments

@orenbm
Copy link
Member

orenbm commented Jun 8, 2020

Summary

Variable IDs are not encoded at all so in case a user has a variable with spaces in it, we are not able to retrieve it.

We should use an encoding method that encodes spaces into "%20" as required
by the Conjur v5 server. We also encode slashes into "%2F" as required.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Create a Conjur variable with a space in its ID, and populate it.
  2. Retrieve it with Puppet

Expected Results

Secret is retrieved

Actual Results (including error logs, if applicable)

404 error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant