Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conjurize lives #108

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Conjurize lives #108

merged 2 commits into from
Jul 8, 2020

Conversation

izgeri
Copy link
Contributor

@izgeri izgeri commented Jul 8, 2020 •
edited
Loading

What does this PR do?

  • Adds back in the conjurize instructions with a big Conjur v4 only! caveat (we will deprecate this, likely at the end of milestone 2)
  • Removes v6 support from README, as we're not formally announcing this until the end of milestone 2

Note: I also filed #107 to review the supported versions of all agent types and update them before Milestone 2 wraps up.

What ticket does this PR close?

n/a

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@izgeri izgeri requested a review from a team as a code owner July 8, 2020 21:04
@izgeri izgeri self-assigned this Jul 8, 2020
sgnn7
sgnn7 approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izgeri LGTM

@sgnn7 sgnn7 merged commit ba04e6d into master Jul 8, 2020
@sgnn7 sgnn7 deleted the conjurize-lives branch July 8, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgnn7 sgnn7 sgnn7 approved these changes

Assignees

@izgeri izgeri

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izgeri @sgnn7