Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in PDK validate/test #253

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix bug in PDK validate/test #253

merged 1 commit into from
Apr 17, 2023

Conversation

gl-johnson
Copy link
Contributor

@gl-johnson gl-johnson commented Feb 17, 2023

Desired Outcome

The version of puppet included with PDK (6.27.0) is broken due to a change in concurrent-ruby. It appears to be fixed in Puppet 6.29.0, so update the dockerfile to fetch a newer version of PDK

See: ruby-concurrency/concurrent-ruby#988
Fixed by: puppetlabs/puppet#8996

Also address dev tasks around updating Docker base images and upgrading to Ruby 3.

Implemented Changes

  • Run pdk validate and test against a more recent version of Puppet with the fix
  • Update docker base images
  • Fix Windows docker builds by disabling buildkit

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@gl-johnson gl-johnson force-pushed the fix-build-error branch 4 times, most recently from c450cb3 to e70c413 Compare February 21, 2023 20:47
@gl-johnson gl-johnson force-pushed the fix-build-error branch 10 times, most recently from 1957a19 to 19be1d9 Compare April 11, 2023 13:03
@gl-johnson gl-johnson force-pushed the fix-build-error branch 9 times, most recently from 6d0d9f8 to 82b0d7c Compare April 12, 2023 22:40
@gl-johnson gl-johnson marked this pull request as ready for review April 17, 2023 13:06
@gl-johnson gl-johnson requested a review from a team as a code owner April 17, 2023 13:06
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gl-johnson gl-johnson merged commit d977d7a into main Apr 17, 2023
@gl-johnson gl-johnson deleted the fix-build-error branch April 17, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants