Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ruby to 3.2.2 #256

Merged
merged 2 commits into from May 23, 2023
Merged

Upgrade ruby to 3.2.2 #256

merged 2 commits into from May 23, 2023

Conversation

juniortaeza
Copy link
Contributor

@juniortaeza juniortaeza commented May 22, 2023 •
edited

Desired Outcome

This pull request upgrades ruby from 3.2.1 to ruby 3.2.2. Upgrading to 3.2-slim does not seem to be feasible as it caused the build to fail.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@juniortaeza juniortaeza requested a review from a team as a code owner May 22, 2023 20:10
@juniortaeza juniortaeza changed the title Upgrade ruby to 3.2-slim Upgrade ruby to 3.2 May 23, 2023
@juniortaeza juniortaeza changed the title Upgrade ruby to 3.2 Upgrade ruby to 3.2.2 May 23, 2023
gl-johnson
gl-johnson approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juniortaeza juniortaeza merged commit ee93d67 into main May 23, 2023
1 check passed
@john-odonnell john-odonnell deleted the upgrade-ruby-branch branch May 30, 2023 15:03
@gl-johnson gl-johnson mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gl-johnson gl-johnson gl-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juniortaeza @gl-johnson