Notifications appearing more than once #83

Closed
cyberbit opened this Issue Dec 4, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@cyberbit
Owner

cyberbit commented Dec 4, 2015

Via Tom Bellinger. The intended design is for notifications to appear once, then sit in the queue until updated (dismissed, action taken, etc.). The problem may be with how I'm implementing the chrome.notifications API (specifically the update method).

@cyberbit cyberbit added the bug label Dec 4, 2015

@cyberbit cyberbit self-assigned this Dec 4, 2015

@cyberbit cyberbit added this to the Options milestone Dec 4, 2015

@cyberbit cyberbit added the inwork label Dec 28, 2015

@cyberbit

This comment has been minimized.

Show comment
Hide comment
@cyberbit

cyberbit Dec 28, 2015

Owner

It looks like the API is no longer persisting notifications until dismissed, so the notifications are just being created and shown every time. Currently implementing solution that forces notifications to only be shown once. I'm planning on replacing the notification list in the popup window with a button that displays all the rich notifications instead (see #61)

Owner

cyberbit commented Dec 28, 2015

It looks like the API is no longer persisting notifications until dismissed, so the notifications are just being created and shown every time. Currently implementing solution that forces notifications to only be shown once. I'm planning on replacing the notification list in the popup window with a button that displays all the rich notifications instead (see #61)

@cyberbit

This comment has been minimized.

Show comment
Hide comment
@cyberbit

cyberbit Dec 28, 2015

Owner

Notifications now only appear once. Showing all notifications is implemented and working in the event page, so the "Show Notifications" button in the popup window needs to trigger an event on the event page.

Owner

cyberbit commented Dec 28, 2015

Notifications now only appear once. Showing all notifications is implemented and working in the event page, so the "Show Notifications" button in the popup window needs to trigger an event on the event page.

@cyberbit

This comment has been minimized.

Show comment
Hide comment
@cyberbit

cyberbit Dec 28, 2015

Owner

Show Notifications button added and working properly.

Owner

cyberbit commented Dec 28, 2015

Show Notifications button added and working properly.

@cyberbit cyberbit added ready and removed inwork labels Dec 28, 2015

@cyberbit cyberbit removed the ready label Dec 30, 2015

@cyberbit cyberbit closed this Dec 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment