New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login extender #93

Closed
cyberbit opened this Issue Jan 6, 2016 · 4 comments

Comments

Projects
None yet
1 participant
@cyberbit
Owner

cyberbit commented Jan 6, 2016

I had this crazy idea. If I utilized the chrome.cookies API, Modation could extend session cookies to last an indefinite amount of time. CRAZY.

@cyberbit cyberbit added the feature label Jan 6, 2016

@cyberbit cyberbit self-assigned this Jan 6, 2016

@cyberbit cyberbit added this to the TBD milestone Jan 6, 2016

@cyberbit cyberbit modified the milestones: TBD, Watchlist Jan 16, 2016

@cyberbit

This comment has been minimized.

Show comment
Hide comment
@cyberbit

cyberbit Jan 17, 2016

Owner

In theory, it should be working now, but something on the server is pushing new cookies that reset the session state. Might be able to work around it, we'll see.

Owner

cyberbit commented Jan 17, 2016

In theory, it should be working now, but something on the server is pushing new cookies that reset the session state. Might be able to work around it, we'll see.

@cyberbit

This comment has been minimized.

Show comment
Hide comment
@cyberbit

cyberbit Jan 18, 2016

Owner

Looks like it "technically" works, now. I feel like it causes a big performance hit because of the cookie.onChanged handler cloning the storage every time. Perhaps add an options cache in localStorage?

Owner

cyberbit commented Jan 18, 2016

Looks like it "technically" works, now. I feel like it causes a big performance hit because of the cookie.onChanged handler cloning the storage every time. Perhaps add an options cache in localStorage?

@cyberbit

This comment has been minimized.

Show comment
Hide comment
@cyberbit

cyberbit Jan 19, 2016

Owner

Labels for days! Accelerated to release as 2.3 due to demand.

Owner

cyberbit commented Jan 19, 2016

Labels for days! Accelerated to release as 2.3 due to demand.

@cyberbit

This comment has been minimized.

Show comment
Hide comment
@cyberbit

cyberbit Jan 20, 2016

Owner

Implemented options cache globally, hoping that helps with performance.

Mod is (functionally) complete, just need to commit and tag this issue. Release looks good for tomorrow!

Owner

cyberbit commented Jan 20, 2016

Implemented options cache globally, hoping that helps with performance.

Mod is (functionally) complete, just need to commit and tag this issue. Release looks good for tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment