Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve E-puck Model #705

Merged
merged 57 commits into from
Dec 6, 2019
Merged

Improve E-puck Model #705

merged 57 commits into from
Dec 6, 2019

Conversation

DavidMansolino
Copy link
Member

@DavidMansolino DavidMansolino commented Jul 5, 2019 •
edited
Loading

This PR adds various improvements to the e-puck robot model (especially for the v2) and adds the pi-puck extension.

The robot with the pi-puck extension:

e-puck2

Some more ideas to improve the model:

  • Improve the led cylinder by using SolidPipe with a bigger subdivision.
  • Make the led of the led ring smaller and with a higher intensity.
  • Make a model of the battery V2 (rounded + 2 colors).
  • Add the battery connectors.
  • Improve meshes
  • Create PBR textures.
  • Top USB as mesh.

@DavidMansolino DavidMansolino added the enhancement Implementation of a minor feature label Jul 5, 2019
@DavidMansolino DavidMansolino added this to the R2019b.rev1 milestone Jul 5, 2019
@DavidMansolino DavidMansolino self-assigned this Jul 5, 2019
@DavidMansolino
Copy link
Member Author

With fixed body meshes + PBR textures + improved LEDs + USB plug + improved battery mesh (+many more):

e-puck2_2
e-puck2_3

@DavidMansolino
Copy link
Member Author

Some of the improvments are also available for the epuck v1:

revision this branch
e-puck_cross-compilation_1 e-puck_cross-compilation_2

@stefaniapedrazzi stefaniapedrazzi modified the milestones: R2019b.rev2, R2020a.rev1 Dec 2, 2019
@DavidMansolino DavidMansolino changed the base branch from revision to develop December 4, 2019 15:21
@DavidMansolino DavidMansolino modified the milestones: R2020a.rev1, R2020a Dec 4, 2019
@DavidMansolino DavidMansolino marked this pull request as ready for review December 5, 2019 07:52
@DavidMansolino
Copy link
Member Author

👍 ✔️

@DavidMansolino DavidMansolino requested a review from a team December 5, 2019 15:51
fabienrohrer
fabienrohrer reviewed Dec 5, 2019
View reviewed changes
projects/robots/gctronic/e-puck/worlds/.e-puck2_pi-puck.wbproj Outdated
selectionDisabled: 0
viewpointLocked: 0
orthographicViewHeight: 1
textFiles: -1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be good to open the controller file there?

fabienrohrer
fabienrohrer previously approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@fabienrohrer fabienrohrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it's very good to me.

@DavidMansolino
Copy link
Member Author

👍

@DavidMansolino DavidMansolino merged commit 45a65f2 into develop Dec 6, 2019
@DavidMansolino DavidMansolino deleted the enhancement-e-puck branch December 6, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabienrohrer fabienrohrer fabienrohrer approved these changes

Assignees

@DavidMansolino DavidMansolino

Labels
enhancement Implementation of a minor feature
Milestone
R2020a
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidMansolino @fabienrohrer @stefaniapedrazzi