Skip to content
This repository has been archived by the owner on Feb 24, 2022. It is now read-only.

can't cache config #5

Closed
CaddyDz opened this issue Oct 24, 2018 · 1 comment
Closed

can't cache config #5

CaddyDz opened this issue Oct 24, 2018 · 1 comment

Comments

@CaddyDz
Copy link

CaddyDz commented Oct 24, 2018

This is related to using a closure in this function

$this->overwriteAppEditor(function ($filePath, $line) use ($editorConfig) {
            $filePath = $this->resolveFilePath($filePath);

            if (is_string($editorConfig)) {
                return $this->buildUri($editorConfig, $filePath, $line);
            }

            $editorConfig['url'] = $this->buildUri($editorConfig['url'], $filePath, $line);

            return $editorConfig;
        });
@antonkomarev
Copy link
Member

Thanks for the feedback @CaddyDz!

You are right, closures aren't cacheable. But since this feature isn't meant to be used on production and this package required as dev dependency - then it will be used only on developer's machines only.

@CaddyDz CaddyDz closed this as completed Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants