New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage not allowed for width settings #183

Closed
GoogleCodeExporter opened this Issue Apr 4, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 4, 2015

What versions of WordPress and Geo Mashup are you using? WP 2.7.1 and Geo 
Mashup 1.2.2

For problems, describe the problem and provide a URL where the problem is
happening.

Http://www.technomadia.com

For a feature request, describe the feature.

I had been using the WP Geo plugin, and I liked how I could define map size as 
a percentage or 
based upon pixels.  My site layout is based on dynamic widths, and it looks 
fabulous to have maps 
fill the window.  I am now using Geo Mashup and loving it, but I really wish 
there was a way to do 
the variable width maps.

Original issue reported on code.google.com by rad...@gmail.com on 30 Mar 2009 at 10:43

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 4, 2015

Ah, I actually missed that update to the documentation. In 1.2.x you should be 
able
to specify a width like 80%.

Original comment by dylankk...@gmail.com on 30 Mar 2009 at 1:04

  • Changed state: Resolved
  • Added labels: Type-Defect
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 4, 2015

The UI does not allow it.  If I set a percentage value in the control panel, I 
get this:

"Some invalid options will not be used. If you've just upgraded, do an update 
to initialize new options.

"80%" is invalid for width, which must be a number"

Thoughts?

   - Chris

Original comment by rad...@gmail.com on 30 Mar 2009 at 5:07

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 4, 2015

That's a bug. To work around it for now, you'll have to put the width in your 
tags

[geo_mashup_map width="80%"]

or

<?php echo GeoMashup::map('width=80%'); ?>

Original comment by dylankk...@gmail.com on 30 Mar 2009 at 5:54

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 4, 2015

Should be fixed in r385:

http://code.google.com/p/wordpress-geo-mashup/source/browse/trunk/geo-mashup/geo
-mashup-options.php?spec=svn385&r=385

Original comment by dylankk...@gmail.com on 31 Mar 2009 at 4:51

  • Changed title: Percentage not allowed for width settings
  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 4, 2015

Released in 1.2.3.

Original comment by dylankk...@gmail.com on 24 Apr 2009 at 3:21

  • Changed state: Released
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 4, 2015

does this work?

<?php echo GeoMashup::map('width=80%', 'height=100%'); ?>

or is there another way to specify both width & height in % ?
Thanks

Original comment by herbert....@gmail.com on 30 Sep 2009 at 3:47

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 4, 2015

I think percentage hieght is allowed, but your syntax is a little off, you'd 
need:

<?php echo GeoMashup::map( 'width=80%&height=100%' ); ?>

Be aware that percentage height is not always what people think it is:

http://www.w3.org/TR/CSS2/visudet.html#the-height-property

Original comment by dylankk...@gmail.com on 30 Sep 2009 at 1:22

  • Added labels: Milestone-1.2.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment