Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Fix status message placement #102

Closed
raineorshine opened this issue Oct 14, 2019 · 1 comment
Closed

Mobile: Fix status message placement #102

raineorshine opened this issue Oct 14, 2019 · 1 comment
Assignees

Comments

@raineorshine
Copy link
Contributor

@raineorshine raineorshine commented Oct 14, 2019

The status message (Connecting, Offline, etc) should be position: fixed in the upper right hand corner regardless of desktop or mobile. It was not properly repositioned when moved to the footer on mobile.

Use the same effective (i.e. visible) margin and padding as the current desktop positioning.

See /components/Footer.js and App.css

@raineorshine raineorshine added this to the New User milestone Oct 14, 2019
@thackley

This comment has been minimized.

Copy link
Contributor

@thackley thackley commented Oct 22, 2019

In browser.js isMobile = true to test for mobile. In status component, set text to something static to see where it's being rendered - remember to remove text when done. Make sure this looks right in dark and light mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.