Modify Pod netrowk setup #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysksuzuki
force-pushed
the
modify-pod-net
branch
from
4ea16a3
to
ff17164
Compare
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
ymmt2005
reviewed
Sep 14, 2021
ymmt2005
requested changes
Sep 14, 2021
v2/pkg/nodenet/pod.go
Outdated
| IPNet: ipnet, | ||
| Scope: unix.RT_SCOPE_UNIVERSE, | ||
| }) | ||
| if err != nil { | ||
| netlink.LinkDel(cLink) | ||
| return fmt.Errorf("netlink: failed to add an address: %w", err) | ||
| } | ||
| err = netlink.AddrAdd(cLink, &netlink.Addr{ | ||
| IPNet: &net.IPNet{IP: containerIPv4, Mask: net.CIDRMask(30, 32)}, |
There was a problem hiding this comment.
net.CIDRMask(30, 32)
This should be defined as a constant, I mean, a variable used as a constant.
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
morimoto-cybozu
requested changes
Sep 15, 2021
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies Pod network setting to have Linux kernel select a global scope address as a source IP in communication between a node and a local Pod. Cilium seems to assume that a source IP is a localhost address, so we tweak Coil's Pod network setup.
With the settings described above, Linux kernel recognizes the communication between a node and a local Pod as L3 and selects a global scope address as a source IP.