Skip to content

Commit 453956c

Browse files
authored
ci: drop Node v6 and add Node v12 as supporting versions (#130)
BREAKING CHANGE: drop Node v6 support
1 parent e262c0a commit 453956c

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

.circleci/config.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@ commands:
1919
- run: npm run lint
2020
- run: npm test
2121
jobs:
22-
node-v6:
23-
docker:
24-
- image: circleci/node:6@sha256:52506adf0ce82ccdf8b652e07741c6796bf6730e305c0b6fb6068044dfb47035
25-
steps:
26-
- run-npm-test
2722
node-v8:
2823
docker:
2924
- image: circleci/node:8@sha256:316f179402ccbe1041a85c73b1ea318ff90123d318a46660e4a27d3bbac6785c
@@ -34,10 +29,15 @@ jobs:
3429
- image: circleci/node:10@sha256:8c1725cd6a55f99ece5bad3b153a8d8b8bc0fe93cea862b53d8c3823ff0ae371
3530
steps:
3631
- run-npm-test
32+
node-v12:
33+
docker:
34+
- image: circleci/node:12
35+
steps:
36+
- run-npm-test
3737

3838
workflows:
3939
multiple_builds:
4040
jobs:
41-
- node-v6
4241
- node-v8
4342
- node-v10
43+
- node-v12

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@cybozu/eslint-config",
33
"engines": {
4-
"node": ">=6"
4+
"node": ">=8"
55
},
66
"repository": "cybozu/eslint-config",
77
"homepage": "https://github.com/cybozu/eslint-config",

test/fixtures/node/error.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
1+
// prettier-ignore
12
require('./unknown');
23

34
(async () => {
4-
await new Promise(r => r);
5-
})();
5+
try {
6+
await new Promise(r => r);
7+
} catch {
8+
console.log(1);
9+
}
10+
})();

0 commit comments

Comments
 (0)